exiv2 icon indicating copy to clipboard operation
exiv2 copied to clipboard

Examine usage of XPathIo and EXV_XPATH_MEMIO

Open piponazo opened this issue 4 years ago • 1 comments

The class XPathIo seems to have different implementations depending on EXV_XPATH_MEMIO. However that definition is hard-coded in the file basicio.hpp:39.

We should investigate:

  • if it makes sense to have both implementations in the codebase.
  • In the last years we have been using the XPathIo which is inhering from FileIO. Could we obtain any benefit from using the MemIO one?
  • That class seems to be only used in ImageFactory::createIo.
  • In case we want to keep both implementations, we should at least make possible to choose which implementation to use at configuration time (Via CMake options).

piponazo avatar Jan 05 '22 16:01 piponazo

I don't remember anything about this class. It may have been something that @vok added to deal with extended attributes on the Mac.

clanmills avatar Jan 05 '22 16:01 clanmills