EXILED icon indicating copy to clipboard operation
EXILED copied to clipboard

Scp3114::Dancing event

Open VALERA771 opened this issue 2 years ago • 6 comments

VALERA771 avatar Dec 15 '23 18:12 VALERA771

I think NewState setter can be removed. Or NewState at all can be

VALERA771 avatar Dec 15 '23 19:12 VALERA771

[SUGGESTION] is it possible to choose wish dance is made and possibly having an Enum for it ?

As far as I tested, it'll cause some wierd bugs

VALERA771 avatar Feb 07 '24 18:02 VALERA771

[SUGGESTION] is it possible to choose wish dance is made and possibly having an Enum for it ?

As far as I tested, it'll cause some wierd bugs

So you can add the Dance play as getter

louis1706 avatar Feb 07 '24 19:02 louis1706

[SUGGESTION] is it possible to choose wish dance is made and possibly having an Enum for it ?

As far as I tested, it'll cause some wierd bugs

So you can add the Dance play as getter

Not possible. Patching that method in any way will cause some bugs

VALERA771 avatar Feb 09 '24 06:02 VALERA771

We still have the biggest problem - how to name dance types

VALERA771 avatar May 13 '24 16:05 VALERA771

We still have the biggest problem - how to name dance types

https://github.com/creepycats/EmoteForAll-SL/blob/main/Types/Scp3114DanceType.cs

louis1706 avatar May 14 '24 22:05 louis1706

Change Scp3114Role::StatDancing to Scp3114Role::StartDancing

obvEve avatar May 22 '24 15:05 obvEve

We still have the biggest problem - how to name dance types

https://github.com/creepycats/EmoteForAll-SL/blob/main/Types/Scp3114DanceType.cs

Does the numeration right? We really rely on number of enum in this case

VALERA771 avatar May 26 '24 16:05 VALERA771

Does the numeration right? We really rely on number of enum in this case

Looks like it should be working

obvEve avatar May 26 '24 20:05 obvEve