EXILED icon indicating copy to clipboard operation
EXILED copied to clipboard
verified publisher icon Exiled-Team

(Breaking changes)Scp914 events rework

Open IRacle1 opened this issue 3 years ago • 3 comments

IRacle1 avatar May 07 '22 15:05 IRacle1

Plz, add a "do not merge"

IRacle1 avatar May 08 '22 12:05 IRacle1

I'm not certain the eventargs renaming is necessary, seeing as it's in an event in the Events.Handlers.Scp914 class already. But this being a breaking change means it won't be merged for a decently long time.

joker-119 avatar May 10 '22 09:05 joker-119

I'm not certain the eventargs renaming is necessary, seeing as it's in an event in the Events.Handlers.Scp914 class already. But this being a breaking change means it won't be merged for a decently long time.

I personally believe this is necessary. It can cause confusion otherwise. Imagine if Scp330 handler had an "Interacting" event and an "InteractingEventArgs" ev.

Thundermaker300 avatar Aug 15 '22 23:08 Thundermaker300