xud icon indicating copy to clipboard operation
xud copied to clipboard

Translate gRPC calls to make them CCXT-compatible

Open kilrau opened this issue 7 years ago • 13 comments

We aim to make xud's main calls ccxt compatible, so that professional traders can easily connect their existing GUI + algorithms. As per https://github.com/ExchangeUnion/xud/issues/471#issuecomment-441451581 we will not start a GUI project on our own.

Here is the full list of all unified ccxt API methods (subset of methods common among the exchanges) which we should support. I suggest to do this with a ccxt wrapper, not touching existing calls. The CLI is not affected and can stay as is. Goes without saying - we'll keep all other calls as is

kilrau avatar Nov 26 '18 10:11 kilrau

@kilrau Is anyone planning to work on this? if not I will take it.

ImmanuelSegol avatar Dec 29 '18 21:12 ImmanuelSegol

Please, but let's discuss on the way how to do this - if via ccxt wrapper around our current gRPC or change the gRPC

kilrau avatar Jan 02 '19 15:01 kilrau

@kilrau @sangaman We should discus this on the weekly meeting.

ImmanuelSegol avatar Jan 13 '19 13:01 ImmanuelSegol

@kilrau @sangaman We should discus this on the weekly meeting.

Sure! Weekly call on Wednesday 16:00 UTC+1

kilrau avatar Jan 14 '19 05:01 kilrau

Any questions left? @ImmanuelSegol

kilrau avatar Jan 23 '19 13:01 kilrau

https://sparkswap.com/docs/integration/ccxt

kilrau avatar Apr 16 '19 07:04 kilrau

I'm not familiar with CCXT and I don't think it's been brought up on one of the calls, but we can discuss next time. I'd expect that it'd be better to have a wrapper around our existing API.

sangaman avatar Apr 19 '19 04:04 sangaman

I'd expect that it'd be better to have a wrapper around our existing API.

That's what I thought too!

Please bring this up on our next call on Wednesday and definitely don't accept that we skip you again! ;)

kilrau avatar Apr 19 '19 21:04 kilrau

CLI is enough for 1.0.0. Moving to post-1.0.0.

kilrau avatar May 08 '19 15:05 kilrau

Is this open to work? I would like to take this if this is avaible to work. And if I can work on this, can you give estimation salary?

xVETTEx avatar Feb 12 '20 12:02 xVETTEx

It is! Added estimation. I suggest to keep us in the loop on how exactly you plan to implement this to make sure you are heading into the right direction!

kilrau avatar Feb 12 '20 17:02 kilrau

@kilrau I think we need provide http api on xud if we want to use api trough ccxt. So I'll create grpc services for every ccxt api endpoint?

xVETTEx avatar Mar 03 '20 21:03 xVETTEx

I think we need provide http api on xud if we want to use api trough ccxt.

gRPC is HTTP(/2)

So I'll create grpc services for every ccxt api endpoint?

gRPC wrapper services, internally pointing to the existing gRPC calls. That's at least how I imagined it. Thoughts? @sangaman @erkarl

I would like to take care of https://github.com/ExchangeUnion/market-maker-tools/issues/1 first though.

kilrau avatar Mar 04 '20 10:03 kilrau