binary-install icon indicating copy to clipboard operation
binary-install copied to clipboard

Fix package not working with Yarn PnP

Open adalinesimonian opened this issue 1 year ago • 0 comments

As this package commits the cardinal sin of writing into its own package directory, and Yarn's whole imperative is to nuke bad patterns out of orbit, it doesn't work with Yarn PnP. Therefore, there are two options to get this working:

  1. Modify the logic such that the package does not write to itself and binaries are written elsewhere.
  2. preferUnplugged: true and let Yarn extract the package into a disgustingly mutable directory.

This PR implements the latter because it took me two seconds.

With this change, Yarn users using PnP should no longer have any issues using rover and should no longer need to run an unplug command manually to get it working. Tada.

adalinesimonian avatar Feb 25 '24 04:02 adalinesimonian