EtherealEngine
[Bug]: github oauth admin panel broken
Version
0f27df2(1.5.0)
Operating Systems
- [ ] macOS
- [ ] Windows
- [ ] Linux
- [ ] Android
- [ ] IOS
Browser (if applicable)
No response
What is supposed happened?
Clicking on github in admin user settings should allow github auth
What happened?
error of something undefined
Steps to reproduce
Create account on dev.etherealengine.com/admin and try to add github auth in user prefs
Relevant Info
No response
This is an annoyingly intermittent bug that results from an OAuth provider not returning information. We create the identityProvider.token from the sub or name on this information, but if it's absent, then that logic is trying to read a value off of undefined, and throws an error. Deleting one's user and making a new one via OAuth seems to correct the problem for some reason, after which it can't be triggered again.
Even conditionally getting .sub or .name from the info wouldn't solve the problem, because other parts of our logic wouldn't work without this information from the OAuth provider. Closing this until someone can trigger it again.
Ran into this again on a new cluster, with a new GH oauth app after authorizing the new app to have accessing to various repos. Potentially repeatable with new OAuth apps.
Testing locally with multiple brand-new OAuth apps did not trigger the problem.