Essentials icon indicating copy to clipboard operation
Essentials copied to clipboard

Add give argument to skull command

Open Yurakaii opened this issue 1 year ago • 2 comments

Information

This PR closes #5762.

Details

Proposed feature:
This adds the ability to give a skull to another player using the /skull command with a second argument, if you only provide one argument the command will work as it previously did.

The new usage of the skull command is: /<command> [owner] [player]

Environments tested:

OS: Windows 11

Java version: 21

  • [x] Most recent Paper version (1.20.6, git-Paper-137)
  • [ ] CraftBukkit/Spigot/Paper 1.12.2
  • [ ] CraftBukkit 1.8.8

Demonstration:

This gives the dinnerbone's skull to trashdrumlinfly: Screenshot 2024-06-05 144150

trashdrumlinfly received dinnerbone's skull Screenshot 2024-06-05 143929

The command can still be used as how it worked before by just providing the first argument.

Yurakaii avatar Jun 05 '24 19:06 Yurakaii

bump

CatTeaA avatar Aug 26 '24 08:08 CatTeaA

overall looks fine, can you just update the skullCommandUsage messages in the messages.properties file

Apologies for the interruption, can this PR be merged now? I would like to utilize this feature in the menu to provide players with skulls.

Huge-mistake avatar Oct 16 '24 09:10 Huge-mistake

Thanks for the contribution :)

JRoy avatar Nov 25 '24 01:11 JRoy