EssentialsX
Adds full support for socialspy in EssentialsDiscord
Information
This PR closes #5586.
Details
Proposed feature:
Adds support for socialspy (viewing private messages) in EssentialsDiscord.
Environments tested:
OS: MacOS 14.1
Java version: Temurin-17.0.10+7
- [x] Most recent Paper version (1.20.4, git-Paper-393)
- [ ] CraftBukkit/Spigot/Paper 1.12.2
- [ ] CraftBukkit 1.8.8
Demonstration:
Looks great (I already ended up making a custom extension to do this because it was so needed for our moderation ability. It would be amazing to have it as a built in). Personally though I'd prefer it if the naming and formatting was more consistent with the rest of EssentialsX and EssentialsXDiscord namely:
- I think the message formatting should mirror the socialspy formatting. That is instead of
{sender-username} -> {receiver-username}: {message}i think[SS][{sender-displayname} -> {receiver-displayname}]: {message}or similar is more appropriate. - I think the message type name in the config should be something like
socialspyorprivate-messagein the same style as the other message types.
I think the message formatting should mirror the socialspy formatting. That is instead of
{sender-username} -> {receiver-username}: {message}i think[SS][{sender-displayname} -> {receiver-displayname}]: {message}or similar is more appropriate.
I have a PR to make the Social Spy messages configurable to use either the player name or the display name (because player names are so much better for SS messages).
If that does go through (which it really should display names versus player names are very much a thing that should be configurable) i think the socialspy formatting here should still mirror the in game socialspy formatting and it's defaults. If the default changes to socialspy using player names then this should default to player names too in my opinion. It's essentially the same message they should have the same default formatting.