Update samples/hey_gis_give_me_a_map_of_the_recent_natural_disasters
Updated the text and some of the mapping calls, but need some sage wisdom from Nanae about some of the other mapping stuff first before merging. Mainly:
- Hit command f to find the cell about "show_styles". Is there any replacement of that functionality in the new stuff?
- Is there a take_screenshot method or something comparable in new widget?
- Does spatial.plot on dataframes still work the same or should we adjust around that?
Thanks and lmk :)
Check out this pull request on ![]()
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
View / edit / reply to this conversation on ReviewNB
nanaeaubry commented on 2024-10-21T08:08:04Z ----------------------------------------------------------------
We removed show styles for now... this is something we might want to re-imagine a bit before integrating since we now use the dataclasses. But no one-to-one as of now
View / edit / reply to this conversation on ReviewNB
nanaeaubry commented on 2024-10-21T08:08:05Z ----------------------------------------------------------------
plot now takes a renderer dataclass rather than individual symbol information. So you make a simple renderer and add in the symbol there.
View / edit / reply to this conversation on ReviewNB
nanaeaubry commented on 2024-10-21T08:08:06Z ----------------------------------------------------------------
You can replace with export_to_html since that is mentioned in the comment. But take screenshot we decided not to include. There is also a print method. So maybe change the text to:
" Alternatively, you can either print to PDF of the current map, or export it to a local HTML file. "
And then change the code to one or the other. Take screenshot was used because it shows the map rather than the file path is my guess
@nparavicini7 Left some comments for your questions, let me know if you need more info!