Fix various string formatting warnings

[turboencabulator]

This fixes a handful of warnings where the format strings disagree with the variable type, plus replacing a deprecated function.

As an aside, Qt's string handling is really inconsistent so there are 4 different styles here. QString::arg is the preferred type-safe way to do string formatting, except it doesn't support const char * and you have to use QString::asprintf. qDebug supports C-style format strings and the safer but uglier C++-style stream insertion, but qFatal only supports the format strings.

[mi-hol]

I'm lacking the technical skills to review but support the goal "reduce warnings" in source code. The changes look to be minor, with low risk of creating new issues.

In case no other maintainer objects within next 2 days (a kind of "passive approval"), please go ahead and merge.

[mi-hol]

In case no other maintainer objects within next 2 days (a kind of "passive approval"), please go ahead and merge.

@espotek-org/maintainers Oops, please apologize I missed to copy you all on this suggestion for agreeing on some basic rules of collaboration. Now merging has already happened. My fault. It wasn't my intention to take decisions without agreement or at least giving the opportunity to object.

Nevertheless, are you all ok with the suggested approach summarized below?

• emergency fixes (i.e. fix build error, remove faulty build from releases) can be performed by every maintainer at any time
• changes done by maintainers with low risk of creating new issues, require no mandatory review and will be merged after 2 days passed via passive approval
• other changes require an active approval by another maintainer

Are additional rules beneficial? Is a chat communication channel, limited to maintainers, beneficial? Any other topic to be discussed?

[mmehari]

Since recently, the development pace has picked up and assuming it will keep on this way, I would say having a separate communication channel is beneficial. For the rest, I am OK with the summarized maintainership approach.

[turboencabulator]

Those rules sound perfectly reasonable to me.

[mi-hol]

Those rules sound perfectly reasonable to me.

Thanks

re "Is a chat communication channel, limited to maintainers, beneficial?" was there no comment intentionally? You are currently the only one I can't contact via email privately

[turboencabulator]

re "Is a chat communication channel, limited to maintainers, beneficial?" was there no comment intentionally?

I didn't really have an opinion on it. But thinking about it a bit more, and in the spirit of openness, I'm more in favor of just using the Github Discussions features over setting up some sort of private chat system. I imagine we're all in widely different time zones and have limited time to devote to this.

You are currently the only one I can't contact via email privately

Interesting. Does the email address in my commit messages not work for you, or did I just miss it?

[mi-hol]

Does the email address in my commit messages not work for you, or did I just miss it?

GH hides them, visible is just a generic "[email protected]"