Graphene icon indicating copy to clipboard operation
Graphene copied to clipboard

Graphene: Resource texts and the modal texts of the Microapps are not readable in the night theme

Open alikemaltanriverdi opened this issue 3 years ago • 6 comments

Description The text of the resources, the texts in the modals when creating a new/edit script, new/edit template, new/edit forms are not readable in the night theme of the browsers. It seems like the text colors for those mentioned above are white which make them really hard to read in the night theme of the Graphene.

Feature / Subsystem Graphene

To Reproduce

  1. Go to https://my.binghamton.edu/admin/apps/278
  2. See that the resources are not readable
  3. Go to scripts tab/ templates tab/ forms tab and click on "New/ Edit Name (or New Form/ Edit Form Name)", and see that the text is not readable in the modal

Console Errors No error

Link(s) https://my.binghamton.edu/admin/apps/278

Additional context Please see the screenshots, and let me know if you require any additional documentation. Resources: Screen Shot 2022-10-24 at 11 02 05 PM New/Edit Script: Screen Shot 2022-10-24 at 11 02 19 PM New/Edit Template: Screen Shot 2022-10-24 at 11 02 28 PM

alikemaltanriverdi avatar Oct 25 '22 03:10 alikemaltanriverdi

I also have this issue

nwallin1 avatar Oct 27 '22 14:10 nwallin1

Who added a night theme?

Cloverstone avatar Nov 02 '22 15:11 Cloverstone

@Cloverstone -- no idea, not sure if anyone made a deliberate change, but it appears to only have any impact in the Admin view when editing a micro-app. No apparent changes anywhere else on the site including when editing workflows or anywhere else in the admin.

timcortesi avatar Nov 02 '22 15:11 timcortesi

Yeah - It was a bit tongue-in-cheek. There is no "night theme" - if you set your system to force dark mode then the browser changes defaults but that's all that's happening.

Cloverstone avatar Nov 02 '22 15:11 Cloverstone

Following up on this "theme" issue, I can currently read the text on the "Resources" tab of a Microapp edit page just fine, but now the text on all the widgets/sidebar content in the Form Editor is white/blank. This was not the case for me a while ago when the other theme issues were happening, so perhaps there was a code change in the form library that affected only the rendering on the form editor?

Nynergy avatar Dec 05 '22 16:12 Nynergy

Thanks fo the update, I will take a look.

On Mon, Dec 5, 2022 at 11:29 AM Benjamin Buchanan @.***> wrote:

Following up on this "theme" issue, I can currently read the text on the "Resources" tab of a Microapp edit page just fine, but now the text on all the widgets/sidebar content in the Form Editor is white/blank. This was not the case for me a while ago when the other theme issues were happening, so perhaps there was a code change in the form library that affected only the rendering on the form editor?

— Reply to this email directly, view it on GitHub https://github.com/EscherLabs/Graphene/issues/246#issuecomment-1337666367, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMBGEO4GXRVFITQ6POTIHTWLYJ47ANCNFSM6AAAAAARNRO73I . You are receiving this because you were mentioned.Message ID: @.***>

-- Adam Smallcomb Business Architect/Analyst Binghamton University (607) 777-6121

Cloverstone avatar Dec 05 '22 17:12 Cloverstone