graphql-armor icon indicating copy to clipboard operation
graphql-armor copied to clipboard

exhaustive alias checking

Open n1ru4l opened this issue 3 years ago • 0 comments

Currently, the max alias rule only checks the maximum count of aliases in a given operation.

Sometimes you are forced to use GraphQL aliases, e.g. when heavily using union and/or interface types for satisfying the OverlappingFieldsCanbeMerged rule (graphql-js implementation; GraphQL Specification).

It might be smart to loosen the alias check (or introduce an additional/alternative rule) that loosens this for such fields and is more targeted towards preventing exhaustive/unnecessary/duplicated/potentially harmful aliases.

n1ru4l avatar Sep 02 '22 10:09 n1ru4l

The easy way here could be to drop aliases limitation. We will keep it for a few versions as it might be useful depending on needs...?

I will work on an alternative rule.

nullswan avatar Sep 08 '22 14:09 nullswan