RAMS icon indicating copy to clipboard operation
RAMS copied to clipboard

Registration function seemingly not doing anything

Open flauted opened this issue 2 years ago • 1 comments

Hello @fsalv ,

I am trying to reproduce your results training a model from scratch and am having some trouble. One thing I've noticed is this:

The register_imgset function L160 returns the input imgset instead of the registered version of the images imgset_reg. See here: https://github.com/EscVM/RAMS/blob/bc16e52b8e2d7b5e23560e14045f13f181d03f77/utils/preprocessing.py#L160

To me this seems like a mistake. Maybe I am missing something?

If this is a mistake, could you please advise if you think your pretrained models were affected?

flauted avatar May 06 '23 14:05 flauted

The table in the paper reports NIR bicubic/RAMS cPSNR=45.12, 48.23.

With the test notebook as-is (using the provided pretrained NIR model), I get 45.57, 48.12.

Changing L160 to return imgset_reg, rerunning preprocessing, and re-testing, I get 45.69, 48.43.

flauted avatar May 06 '23 14:05 flauted