David Sisson

Good discussion, the current design definitely works best here.

While I like this simplification there is on thing I'm concerned about. That is the lack of widespread support for complex types (here list and structs). A simplistic Substrait consumer...

I'm sure this will be discussed at this week's community meeting. In the meantime two possibilities could be taken here: 1. Forget about using a one of and declare that...

Ah, but the goal here is to return all of the data for the table in one expression and not too allow dynamic parameters throughout. So my solutions don't work....

The variadic attribute should allow any number of arguments as long as the minimum of one is provided. There is no maximum specified.

Ah, I see. Both DuckDB and Snowflake use a maximum length for their varchar literals which is different than Substrait Go's behavior. The L1 requirement does seem to be the...

``` { "extensionUris": [ { "extensionUriAnchor": 1, "uri": "/functions_arithmetic.yaml" } ], "extensions": [ { "extensionFunction": { "extensionUriReference": 1, "functionAnchor": 1, "name": "row_number" } } ], "relations": [ { "root": {...

The only other way I know of to do window related behavior is with the ConsistentPartitionWindowRel -- https://github.com/substrait-io/substrait/blob/main/proto/substrait/algebra.proto#L272.

It seems like you'd be able to use the window function expression syntax I first linked to handle AVG OVER as that syntax just needs an operation with partition and...

The Substrait appears to be written with Datafusion's project bug/behavior in mind so it should work for us (and even better it should still work after the bug is fixed)....