Emysql icon indicating copy to clipboard operation
Emysql copied to clipboard
verified publisher icon Eonblast

Fixed build to work with R14,R15,R16,17 and 18

Open djustinek opened this issue 10 years ago • 5 comments

Fixed build scripts and code so it works with latest Erlang/OPT releases.

djustinek avatar Jul 29 '15 11:07 djustinek

Good job!

I propose a change to move the conditional compilation into the .erl files to avoid issues in projects that include the emysql header.

See my patch: howleysv/Emysql@dda35e151917c0f43728c15aa4eee98f5aa6e1d3

howleysv avatar Aug 26 '15 13:08 howleysv

@howleysv : Proposed patch breaks compilation on pre-17 Erlang versions. (https://travis-ci.org/Eonblast/Emysql/builds/77387690)

djustinek avatar Aug 26 '15 20:08 djustinek

Sorry, I should have tested this myself!

I forgot that the built-in types could not be redefined in <17. Renaming to t_type as before seems to work (tested in 18.0 and R16B03-1):

howleysv/Emysql@00d2f864d8cea44a7260d1fccf480a8885e16455

howleysv avatar Aug 26 '15 21:08 howleysv

@howleysv, it's patched. Everything seems fine now.

djustinek avatar Aug 27 '15 05:08 djustinek

Why wouldn't you accept and apply this pull-request? Is something wrong with it or this repository is abandoned?

nazar256 avatar Jan 07 '16 19:01 nazar256