version-check icon indicating copy to clipboard operation
version-check copied to clipboard

Action fails on Windows

Open goerwin opened this issue 5 years ago • 3 comments

Describe the bug Using EndBug/version-check@v2 throws a 404 when the repo is private

To Reproduce Using this workflow:

name: release

on:
  push:
    branches: [master]

jobs:
  release:
    runs-on: ${{ matrix.os }}

    strategy:
      matrix:
        os: [windows-latest]

    steps:
      - name: Check out Git repository
        uses: actions/checkout@v2

      - name: Install Node.js, NPM and Yarn
        uses: actions/setup-node@v2
        with:
          node-version: 14

      - id: check
        name: Verify package.json version change
        uses: EndBug/version-check@v2
        with:
          token: ${{ secrets.GITHUB_TOKEN }}

      - name: push new tag
        if: steps.check.outputs.changed == 'true'
        run: 'git tag v${{ steps.check.outputs.version }}'

result logs captura_2021-04-19_21_01_08

goerwin avatar Apr 20 '21 02:04 goerwin

I've been able to reproduce this, but the issue is not about private repos, but about jobs that run on windows (windows-latest, windows-2019).
I'm working on a rewrite and I'll try to look into this as well. For the time being, I can only suggest you to use another OS for your builds if you can.

EndBug avatar Apr 21 '21 06:04 EndBug

Hi @EndBug ! Do you have any idea what could be the issue for it to be failing on windows? I am happy to contribute with a fix!

halvardssm avatar Sep 22 '21 22:09 halvardssm

@halvardssm Honestly I have no clue ahahha. I haven't got around the rewrite... If you find a fix feel free to open a PR!

EndBug avatar Sep 23 '21 07:09 EndBug