prophet icon indicating copy to clipboard operation
prophet copied to clipboard

Missing Dependencies and Broken Tests

Open aabdullah-bos opened this issue 8 years ago • 2 comments

I forked prophet and then cloned my fork. I then tried to run the quickstart.py example, but it failed because pandas-datareader and seaborn were not installed, they were not installed, because they were not in setup.py file.

Also, the integration test for the quickstart failed, because the YahooData class dose not support cache_data. I fixed this on my fork by adding both cache_path and data_path to the init methods for:

  • YahooData
  • YahooCloseData
  • PandasDataGenerator

You can find my changes in the merge that I made to my fork...

https://github.com/aabdullah-bos/prophet/pull/1

If this is what, you intended. I can submit a pull request to your fork.

aabdullah-bos avatar Sep 28 '17 20:09 aabdullah-bos

Feel free to submit a pull request @aabdullah-bos

Emsu avatar Oct 01 '17 04:10 Emsu

I've submitted the PR https://github.com/Emsu/prophet/pull/26

aabdullah-bos avatar Oct 03 '17 19:10 aabdullah-bos