LimboAPI icon indicating copy to clipboard operation
LimboAPI copied to clipboard

[NOT A BUG] PostLoginEvent and LoginEvent not firing without LimboPlayer#disconnect call

Open kyngs opened this issue 4 years ago • 1 comments

Describe the bug When I add a callback to LoginLimboRegisterEvent, the LoginEvent and PostLoginEvent stop firing completely for all plugins.

To Reproduce Steps to reproduce the behavior:

  1. Add a listener for LoginEvent and PostLoginEvent and put a breakpoint/print statement to it
  2. Add a listener for LoginLimboRegisterEvent and add a callback in it
  3. Try to connect
  4. Observe, that our LoginEvent and PostLoginEvent did not fire

Expected behavior LoginEvent and PostLoginEvent should fire normally.

Screenshots Not applicable

Server Info (please complete the following information):

Additional context I suspect that this is because LimboAPI takes control over the login process when you add a callback, but forgets to fire applicable events which would be fired under a normal scenario.

kyngs avatar Apr 18 '22 18:04 kyngs

I've found out, that I need to call the LimboPlayer#disconnect method for proper handling. I will leave this open, if you want to add further documentation.

kyngs avatar Apr 18 '22 19:04 kyngs