ObsidianCustomFrames icon indicating copy to clipboard operation
ObsidianCustomFrames copied to clipboard

Cannot use urlSuffix with paths

Open Canna71 opened this issue 3 months ago • 2 comments

I think the issue is in this code in frame.ts:

            if (suffix.pathname !== "/") {
                src.pathname += suffix.pathname;
            }

if urlSuffix contains a path (e.g.: foo/bar/page) then by simply concatenating strings, you wnd up with a double forward slash:

https://www.website.com//foo/bar/page

which will lead to 404. I guess it should be handled by properly appending path avoiding slashes duplications.

Canna71 avatar Nov 02 '25 15:11 Canna71

Hi! This should already be fixed by the open pull request #151, which will hopefully be merged soon! :)

Ellpeck avatar Nov 03 '25 09:11 Ellpeck

@Ellpeck thank you so much. I actually ended doing that fix in my local main.js :-)

Canna71 avatar Nov 03 '25 09:11 Canna71