Markdownify icon indicating copy to clipboard operation
Markdownify copied to clipboard

Addressed PHP 8.3 deprecation notices

Open sc0ttdav3y opened this issue 1 year ago • 3 comments

This PR incorporates the work in https://github.com/Elephant418/Markdownify/pull/48, and adds additional properties to fix the deprecation notices since PHP 8.3:

[PHP Decprecated] Creation of dynamic property Markdownify\ConverterExtra::$tableLookaheadHeader is deprecated in /vendor/pixel418/markdownify/src/ConverterExtra.php:87
[PHP Decprecated] Creation of dynamic property Markdownify\ConverterExtra::$tdSubstitute is deprecated in /vendor/pixel418/markdownify/src/ConverterExtra.php:96
[PHP Decprecated] Creation of dynamic property Markdownify\ConverterExtra::$tableLookaheadBody is deprecated in /vendor/pixel418/markdownify/src/ConverterExtra.php:98

I have not been able to test via the included tests, as PHPUnit is still at v4 and this is no longer compatible with PHP 8.3 (and I don't have the time to upgrade it in this PR), however this is a minimal change so it should not have any new bugs.

sc0ttdav3y avatar Sep 24 '24 07:09 sc0ttdav3y

Hi - is this planned to be merged soon? i'm getting the same error upgrading to php 8.3

bradlocking avatar Jun 04 '25 15:06 bradlocking

I can work on it next week. Thanks for your help <3

tzi avatar Jun 05 '25 11:06 tzi

@tzi: how did you get on? Would be good to get this added to a new release 🫶

u01jmg3 avatar Oct 23 '25 15:10 u01jmg3