lightning icon indicating copy to clipboard operation
lightning copied to clipboard

cln-application: bkpr dashboard rpc methods

Open evansmj opened this issue 2 years ago • 2 comments

We are adding a dashboard to cln-application that will track performance of a lightning node over time. This issue is to keep track that we will add new rpc methods for the frontend to call, as opposed to using sql queries.

The data needed would initially support a balance sheet, cash flow, and volume diagram.

Any rpc methods added should have tests written for them.

evansmj avatar Nov 15 '23 21:11 evansmj

we will add new rpc methods for the frontend to call, as opposed to using sql queries.

What features would these new RPC methods support that the sql queries don't currently?

niftynei avatar Nov 21 '23 20:11 niftynei

we will add new rpc methods for the frontend to call, as opposed to using sql queries.

What features would these new RPC methods support that the sql queries don't currently? @niftynei

Hey @ShahanaFarooqui want to chime in?

There is no added functionality with these rpc methods. This came out of conversation with Shahana so there may be additional things but here is what I gather:

Pros:

  • Exposes calls ready for other uses outside of cln-application. (sats flow and balance sheet over time)
  • Stable across database schema changes (would this ever happen?)

Cons:

  • Adds clutter that other rpc users will not use.

The idea was to develop using sql queries, and then when they are finalized see if there is consensus in adding them as new rpc methods.

evansmj avatar Nov 26 '23 18:11 evansmj