#5344 breaks ip autodiscovery for dual stack ipv4/ipv6 nodes with dynamic addresses

Open devastgh opened this issue 3 years ago • 2 comments

Issue and Steps to Reproduce

#5344 will disable ip discovery when autobind finds a usable address. However for nodes with dynamic ipv4 and ipv6 addresses this breaks the functionality, since the (dynamic) ipv6 address is a global adress, and autobind picks it up at start. This results in: no ipv4 address picked up and announced. And when the ipv6 address changes while cln is running, it will not pick that up either. As mentioned in the pr, a --ip-discovery=true/false(/auto) switch could solve this issue, as i could explicity set it to true.

Aug 27 '22 08:08 devastgh

does #5585 or #5584 fix this?

Sep 22 '22 18:09 niftynei

does #5585 or #5584 fix this?

Unfortunately no. This is not a visual issue. If autobind finds any usable address, ip discovery is disabled.

Sep 28 '22 08:09 devastgh