Add native support for liquidtestnet
Currently using liquidtestnet requires a big config file, which is error-prone and uncomfortable for users, this MR adds support for just using -chain=liquidtestnet.
There are a few things that need to be discussed/addressed
- Main port (currently set to 18891 because that's the one used originally, and the one that's configured in
liquidtestnet.com) - RPC and extra ports, I just chose some non-overlapping ports that are "close" to the ones in the other liquid/elements networks.
- Icon color, I just used something different than
liquidv1andelementsregtest, suggestions accepted :wink: -
liquid-testnet.blockstream.comis still using port 18892, it will be changed to 18891 soon. - both seeds are just CNAME dns records at the moment, they should be changed to real seed nodes (no changes in code required, but important for review)
adds support for just using -chain=elementsregtest
should this be -chain=liquidtestnet ?
partially tested ACK 3ccccca
I compiled elementsd and ran it with -chain=liquidtestnet, the daemon connected and started synchronizing the liquid testnet block headers
adds support for just using -chain=elementsregtest
should this be
-chain=liquidtestnet?
Yes, fixed
ACK c6e074e
Tested by compiling the codebase, started elementsd -chain=liquidtestnet sync, and started elements-qt -chain=liquidtestnet sync successfully
ACK https://github.com/ElementsProject/elements/commit/c6e074e25b48b491120a5bad2e0ba1998d8b0dc7
Compiled, installed and ran elements-qt with -chain=liquidtestnet and could sync to tip.
Note: I only tested running without -chain=liquidtestnet briefly - did not wait to sync live to tip.
utACK. My main concern is making sure there is absolutely no accidental behavior change for existing users of custom chains. (As far as I can tell there is not.)
utACK c6e074e25b48b491120a5bad2e0ba1998d8b0dc7