ElMassimo
feat: allow skipping dependencies install.
Description 📖
Add an env flag VITE_RUBY_SKIP_INSTALLING_DEPENDENCIES, which lets users skip installing all node dependencies in the install_dependencies rake task. This is similar to the existing VITE_RUBY_SKIP_INSTALLING_DEV_DEPENDENCIES flag.
Background 📜
The reason our team would like this is the following: We are trying to optimize our CI/CD running time and are working at parallelizing as many tasks as we can. We already installed our dependencies in another step and cached them. When we get to the "assets compilation" step, we would like to use those cached dependencies. Unfortunately, in its current state, the vite dependency installation step not only runs the dependency install again, but it also blows away our cache by using npx ci (which from our understanding uses npm ci in the background).
One workaround we found was using the VITE_RUBY_SKIP_ASSETS_PRECOMPILE_EXTENSION flag, but that skips the assets' precompilation, which we do want. By using that flag, we can then call bin/rake vite:build_all. This path is also acceptable, but I thought others might benefit from this flag instead in order to make their own CI setups easier. I've opened this PR both as a discussion forum and as a potential solution in case it's accepted.
The Fix 🔨
Added a new flag which skips the install_dependencies task.
Screenshots 📷
I was also surprised to find that our CI tests needed Internet access to run Vite compilation; this fix does a great job summarizing the issues we also found independently.
Could it be merged? 🙏
FWIW I also added
Rake::Task["vite:install_dependencies"].clear if Rake::Task.task_defined?("vite:install_dependencies")
In my lib/tasks folder to work around the problem, while waiting for this.
Found an issue trying to use pnpm in CI that caused the mixup of yarn + pnpm to fail. It would ideal to have the possibility to set this env var and let me do the install manually by doing pnpm install in one of the CI steps.
Found an issue trying to use pnpm in CI that caused the mixup of yarn + pnpm to fail. It would ideal to have the possibility to set this env var and let me do the install manually by doing
pnpm installin one of the CI steps.
For me, it was running yarn due to having jsbuild and cssbuild gems included in the gemfile. They come installed by default in a fresh rails installation, so better to remove them before installing vite-ruby.
It would be counter-intuitive if invoking vite:install_dependencies didn't have any effect.
Closing in favor of:
- #451
