io icon indicating copy to clipboard operation
io copied to clipboard

simplifying `promise` and `tryPromise`

Open ricardo-valero opened this issue 2 years ago • 2 comments

Adding promiseWith to reuse in promise and tryPromise Removing new AbortController()

I'm still getting the hang of how everything works, but I thought I'd give it a shot.

ricardo-valero avatar Sep 05 '23 19:09 ricardo-valero

⚠️ No Changeset found

Latest commit: d6279089645c68f024d7a5b82fa284d395b83ee5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Sep 05 '23 19:09 changeset-bot[bot]

well now I'm just curious, but I think with your comments I understand the original code entirely, so I don't see the need for merging (perhaps only the tests?)

still I'd love your feedback on whether my approach is naive in some way, thanks again for your patience!

ricardo-valero avatar Sep 06 '23 21:09 ricardo-valero