Runs both black and flynt formatters against the entire codebase

[srhrshr]

@desilinguist ,

This PR addresses #530 and since we're also planning to include flynt as part of the pre-commit hooks (PR #551 ), I've branched off of that branch and run both flynt and black against the entire code-base.

This seems to have resulted in quite a lot of changes - please take your time with the review and let me know if I can run any additional tests aside from the nosetests.

Thanks!

[pep8speaks]

Hello @srhrshr! Thanks for updating this PR.

• In the file rsmtool/analyzer.py:

Line 168:17: W503 line break before binary operator Line 179:21: W503 line break before binary operator Line 782:13: W503 line break before binary operator Line 783:13: W503 line break before binary operator Line 892:13: W503 line break before binary operator Line 1580:13: W503 line break before binary operator Line 1581:13: W503 line break before binary operator

• In the file rsmtool/comparer.py:

Line 672:17: W503 line break before binary operator Line 673:17: W503 line break before binary operator Line 680:17: W503 line break before binary operator Line 681:17: W503 line break before binary operator

• In the file rsmtool/configuration_parser.py:

Line 237:13: W503 line break before binary operator Line 938:17: W503 line break before binary operator

• In the file rsmtool/modeler.py:

Line 409:13: W503 line break before binary operator Line 1042:13: W503 line break before binary operator

• In the file rsmtool/preprocessor.py:

Line 676:17: W503 line break before binary operator Line 677:17: W503 line break before binary operator Line 1564:13: W503 line break before binary operator Line 1869:13: W503 line break before binary operator Line 1893:17: W503 line break before binary operator Line 1894:17: W503 line break before binary operator Line 1977:13: W503 line break before binary operator Line 2362:17: W503 line break before binary operator Line 2374:17: W503 line break before binary operator Line 2878:21: W503 line break before binary operator

• In the file rsmtool/reporter.py:

Line 354:13: W503 line break before binary operator Line 355:13: W503 line break before binary operator

• In the file rsmtool/test_utils.py:

Line 1169:17: W503 line break before binary operator Line 1170:17: W503 line break before binary operator Line 1171:17: W503 line break before binary operator Line 1172:17: W503 line break before binary operator Line 1173:17: W503 line break before binary operator

• In the file rsmtool/utils/files.py:

Line 62:69: E203 whitespace before ':'

• In the file rsmtool/utils/metrics.py:

Line 281:13: W503 line break before binary operator Line 389:9: W503 line break before binary operator

• In the file rsmtool/utils/models.py:

Line 29:9: W503 line break before binary operator Line 30:9: W503 line break before binary operator

• In the file rsmtool/utils/notebook.py:

Line 288:0: F523 '...'.format(...) has unused arguments at position(s): 0

• In the file tests/compare_config_json.py:

Line 142:21: W503 line break before binary operator Line 143:21: W503 line break before binary operator

• In the file tests/copy_jsons.py:

Line 132:17: W503 line break before binary operator Line 133:17: W503 line break before binary operator

• In the file tests/test_reporter.py:

Line 479:13: W503 line break before binary operator Line 480:13: W503 line break before binary operator Line 484:13: W503 line break before binary operator Line 485:13: W503 line break before binary operator Line 527:13: W503 line break before binary operator Line 528:13: W503 line break before binary operator Line 529:13: W503 line break before binary operator Line 530:13: W503 line break before binary operator Line 577:13: W503 line break before binary operator Line 581:13: W503 line break before binary operator Line 582:13: W503 line break before binary operator Line 583:13: W503 line break before binary operator Line 604:13: W503 line break before binary operator Line 605:13: W503 line break before binary operator Line 606:13: W503 line break before binary operator

• In the file tests/test_utils.py:

Line 151:101: E501 line too long (298 > 100 characters) Line 156:101: E501 line too long (149 > 100 characters) Line 157:101: E501 line too long (166 > 100 characters)

Comment last updated at 2021-10-30 05:07:42 UTC

[srhrshr]

Hello @srhrshr! Thanks for updating this PR.

• In the file rsmtool/analyzer.py:

Line 168:17: W503 line break before binary operator Line 179:21: W503 line break before binary operator Line 782:13: W503 line break before binary operator Line 783:13: W503 line break before binary operator Line 892:13: W503 line break before binary operator Line 1580:13: W503 line break before binary operator Line 1581:13: W503 line break before binary operator

• In the file rsmtool/comparer.py:

Line 672:17: W503 line break before binary operator Line 673:17: W503 line break before binary operator Line 680:17: W503 line break before binary operator Line 681:17: W503 line break before binary operator

• In the file rsmtool/configuration_parser.py:

Line 237:13: W503 line break before binary operator Line 938:17: W503 line break before binary operator

• In the file rsmtool/modeler.py:

Line 409:13: W503 line break before binary operator Line 1042:13: W503 line break before binary operator

• In the file rsmtool/preprocessor.py:

Line 676:17: W503 line break before binary operator Line 677:17: W503 line break before binary operator Line 1564:13: W503 line break before binary operator Line 1869:13: W503 line break before binary operator Line 1893:17: W503 line break before binary operator Line 1894:17: W503 line break before binary operator Line 1977:13: W503 line break before binary operator Line 2362:17: W503 line break before binary operator Line 2374:17: W503 line break before binary operator Line 2878:21: W503 line break before binary operator

• In the file rsmtool/reporter.py:

Line 354:13: W503 line break before binary operator Line 355:13: W503 line break before binary operator

• In the file rsmtool/test_utils.py:

Line 1169:17: W503 line break before binary operator Line 1170:17: W503 line break before binary operator Line 1171:17: W503 line break before binary operator Line 1172:17: W503 line break before binary operator Line 1173:17: W503 line break before binary operator

• In the file rsmtool/utils/files.py:

Line 62:69: E203 whitespace before ':'

• In the file rsmtool/utils/metrics.py:

Line 281:13: W503 line break before binary operator Line 389:9: W503 line break before binary operator

• In the file rsmtool/utils/models.py:

Line 29:9: W503 line break before binary operator Line 30:9: W503 line break before binary operator

• In the file tests/compare_config_json.py:

Line 142:21: W503 line break before binary operator Line 143:21: W503 line break before binary operator

• In the file tests/copy_jsons.py:

Line 132:17: W503 line break before binary operator Line 133:17: W503 line break before binary operator

• In the file tests/test_experiment_rsmtool_1.py:

Line 118:43: F523 '...'.format(...) has unused arguments at position(s): 0

• In the file tests/test_reporter.py:

Line 479:13: W503 line break before binary operator Line 480:13: W503 line break before binary operator Line 484:13: W503 line break before binary operator Line 485:13: W503 line break before binary operator Line 527:13: W503 line break before binary operator Line 528:13: W503 line break before binary operator Line 529:13: W503 line break before binary operator Line 530:13: W503 line break before binary operator Line 577:13: W503 line break before binary operator Line 581:13: W503 line break before binary operator Line 582:13: W503 line break before binary operator Line 583:13: W503 line break before binary operator Line 604:13: W503 line break before binary operator Line 605:13: W503 line break before binary operator Line 606:13: W503 line break before binary operator

• In the file tests/test_utils.py:

Line 151:101: E501 line too long (298 > 100 characters) Line 156:101: E501 line too long (149 > 100 characters) Line 157:101: E501 line too long (166 > 100 characters)

Comment last updated at 2021-10-30 03:44:40 UTC

@desilinguist , Looks like there are conflicting philosophies by pep8 and black around whether a line-break needs to appear before or after a binary operator -- black recommends before and pep8 after. So I've left the line break before binary operator pep8 issues as is and fixed the other line length related issues.