vflow icon indicating copy to clipboard operation
vflow copied to clipboard

support_flow_sample_expanded_and_counter_sample_expanded

Open rachelScout opened this issue 3 years ago • 2 comments

support flow sample expanded and counter sample expanded

rachelScout avatar Oct 23 '22 10:10 rachelScout

I think this change is problematic. It defines a new type called FlowSampleExpand, which has different fields than the regular FlowSample. The expanded format is just a different binary representation of the same data, so it is not reasonable to have a different JSON representation of them. As vflow aims to give a standard representation of the data on wire, regardless of minor differences in encoding, this doesn't sound like the way to go.

Also, there's a lot of code duplication here, while actually the different in compact vs. expanded boils down to just a few differences.

See https://github.com/Edgio/vflow/issues/179 for my detailed suggestion on how to solve this properly.

dbardbar avatar Jan 02 '23 06:01 dbardbar

THIS PR IS LIFE-SAVING. GOD BLESS YOU BRO.

fthrslntgy avatar Aug 16 '23 12:08 fthrslntgy