edgetx icon indicating copy to clipboard operation
edgetx copied to clipboard

Sound files can not be browsed

Open ulfhedlund opened this issue 2 years ago • 19 comments

Is there an existing issue for this problem?

  • [X] I have searched the existing issues

What part of EdgeTX is the focus of this bug?

Transmitter firmware

Current Behavior

I have quite a few sound files (approx 230 in the "en" folder) on my SD card and I have had a few sound related issues.

When I navigate to the SOUNDS/en folder I get only four items listed: SYSTEM, 100.wav, 1000.wav and 10sec.wav. Sound folders with less number of files (yaapu for instance) can be browsed without problems. Sounds already assigned to special functions play as expected but they can not be changed in the Model Settings/Special Functions/Play Track. Nothing visible happens when I click the folder icon in the Value field.

Similar issues also occur in the 2.8.3 simulator, although not identical: clicking on the Special Functions - Play Track - Value field (folder icon) freezes the simulator (and on some occasions also Companion). After navigating to the SOUNDS folder nothing happens when selecting any of the folders or when clicking on the .. (up one level).

On my Xlite running 2.8.3, with the same sound files on the SD card, everything works as expected.

Expected Behavior

All sound files can be browsed even though there are many files in a directory. Any existing sound file can be selected in Special Functions and assigned to a Play Track SF.

Steps To Reproduce

See above

Version

Other (Please specify below)

Transmitter

Radiomaster TX16S / TX16SMK2

Operating System (OS)

Linux

OS Version

Kubuntu 22.04

Anything else?

Firmware 2.8.3, SE language build Companion for Linux (EdgeTx_Companion_2.8.3-x86_64.AppImage)

ulfhedlund avatar Apr 30 '23 20:04 ulfhedlund

My TX16S has no problems with 234 files in the sound folder.

Have you checked the SD card for errors? I would suggest trying a different SD card, or copy all the contents and re-format the card.

philmoz avatar May 01 '23 02:05 philmoz

I created a new SD card and copied all files from my hard drive. However the issues persist. I still can not browse the files in the SC card SOUNDS/en folder. Out of the 874 files (way too many, I know), only the first four entries are listed. And I still can't select any English sound file in the Special Functions - Play Track - Value field.

However, if I change language to "se" (Swedish) I can browse all 230 Swedish sound files and select any of them to play in the Special Functions - Play track. So from my tests so far the issue seems to be related to the large number of sound files on my CD card.

ulfhedlund avatar May 01 '23 17:05 ulfhedlund

This appears to be a limitation in the LVGL lv_table object used by both the file browser and the popup menus (when you select a sound for a special function). The limit seems to be a combination of the number of rows and the row height in the table.

At the moment the limit looks to be 803 rows, so you are limited to 800 sound files (plus the '..', 'SCRIPTS' and 'SYSTEM' folders).

If you want to build a custom firmware you can also decrease the row height for the table cells which will allow more rows. Add the line below to the radio/src/gui/colorlcd/themes/etx_lv_theme.cpp file after line 609. lv_style_set_max_height(&styles.table_cell, 35);

philmoz avatar May 02 '23 01:05 philmoz

OK, so more of a limitation for color radios rather than a bug. Thank you for investigating this, good to know.

I have no use of all sound files, many are remnants from early use of OpenTX and have been added to over the years. I'll remove some of them instead of custom building the firmware.

It is quite cumbersome to navigate in the long list of files even with "only" 200 something files. A page down or some other way of quickly scrolling a long list of files would be handy.

Should this issue now be closed, or managed in another way? Should I do it or will one of you developers take care of it?

ulfhedlund avatar May 02 '23 10:05 ulfhedlund

So it is more a limitation of the maximum height of a single object?

gagarinlg avatar May 02 '23 10:05 gagarinlg

I decreased the the number of files to less than 800, which solved this issue just as explained by philmoz.

ulfhedlund avatar May 02 '23 16:05 ulfhedlund

I have the same problem too. Radio boxer, latest version of edgetx. From the sys menu I can browse and play the sounds in SOUNDS/en. From the special functions play sound the system says "no sounds on sd card". I tried leaving only 2 files in SOUNDS/en but the result doesn't change (no other folders inside SOUNDS, only en)

ripperhack avatar Mar 27 '24 07:03 ripperhack

Is SYS -> Radio Setup -> Voice Language is set to 'EN'?

https://manual.edgetx.org/v/v2.9/b-and-w-radios/radio-settings/radio-setup

Voice language - Language for the voice pack. This setting and the voice pack folder on the SD card must match for the sounds to be played.

And is the path is exactly /SOUNDS/en, i.e. /SOUNDS/en/acro.wav, /SOUNDS/en/SYSTEM/0000.wav?

B&W is a completely different beast to colorlcd, so it won't be the same problem here.

pfeerick avatar Mar 27 '24 08:03 pfeerick

sorry, you're right, I didn't read the radio model. However the language is correct in the sys menu and the path is exactly as you suggest. It doesn't matter... I'll live without having audio :) thx @pfeerick

ripperhack avatar Mar 27 '24 08:03 ripperhack

Hm... okay... so

  • path is correct
  • voice language is correct
  • sound actually works if you play the files via sd browser
  • SF "Play Track" says there are no sounds on the card (implying /SOUNDS/en is empty)

Since you get sound, no need to check the speaker connection or volume settings... that's a new one...

What version of ETX... 2.9.4, 2.10.0-rc1, something else? And just double checking... it's /SOUNDS/en etc, not /SOUNDS/SOUNDS/en?

pfeerick avatar Mar 27 '24 08:03 pfeerick

exactly, everything is correct (checked 20 times). EdgeTX "Providence" version v2.9.4 latest

I think it's an SD problem (new, 64Gb, fat32, formatted).

Copied / pasted from old to new with pc mac

This evening I'll try to do it again with another SD (32Gb) from a Windows PC

I'll update tomorrow

ripperhack avatar Mar 27 '24 08:03 ripperhack

I have the same problem too. Radio boxer, latest version of edgetx. From the sys menu I can browse and play the sounds in SOUNDS/en. From the special functions play sound the system says "no sounds on sd card". I tried leaving only 2 files in SOUNDS/en but the result doesn't change (no other folders inside SOUNDS, only en)

Also play sound doesn't actually look for sd card files since it plays synthetized frequencies with choices like beeps, maybe you meant play track ?

3djc avatar Mar 27 '24 08:03 3djc

Hm... very strange... if you can play them via the sdcard browser, it shouldn't even be that really, as the radio can clearly read the sd card/files (it has to be able to, otherwise it basically wouldn't work).

pfeerick avatar Mar 27 '24 08:03 pfeerick

Hm... very strange... if you can play them via the sdcard browser, it shouldn't even be that really, as the radio can clearly read the sd card/files (it has to be able to, otherwise it basically wouldn't work).

Could be naming

3djc avatar Mar 27 '24 09:03 3djc

my idea is that by doing the sd with mac pc it automatically added hidden folders or something with spotlight

ripperhack avatar Mar 27 '24 09:03 ripperhack

my idea is that by doing the sd with mac pc it automatically added hidden folders or something with spotlight

While true (the hidden files), it poses no issue

3djc avatar Mar 27 '24 09:03 3djc

Tomorrow I'll update you on the test I'm doing this evening with a new SD card made without copying/pasting and let's see what happens

ripperhack avatar Mar 27 '24 09:03 ripperhack

Problem solved, new SD with Windows PC. Copy/paste from the old one. Tried again with the old one made with Mac, it doesn't work

ripperhack avatar Mar 28 '24 06:03 ripperhack

ouch! Well, at least it works now. :smile:

pfeerick avatar Mar 28 '24 08:03 pfeerick