edgetx icon indicating copy to clipboard operation
edgetx copied to clipboard

Buttons look different for Model Setup and

Open mha1 opened this issue 3 years ago • 7 comments

Is there an existing issue for this problem?

  • [X] I have searched the existing issues

What part of EdgeTX is the focus of this bug?

Companion Simulator

Current Behavior

Button in Radio Setup with Background: image

Same button type in Radio Settings e.g. TOOLS and RADIO SETUP without background: image image

Expected Behavior

consistent graphical represantation

Steps To Reproduce

Browse through menus

Version

Nightly (Please give date/commit below)

Transmitter

Radiomaster TX16S

Anything else?

No response

mha1 avatar Sep 11 '22 06:09 mha1

Ah, good point... looks like they are using different colors - can actually see it side by side here with the first one - the labels button ;)

image image

pfeerick avatar Sep 12 '22 00:09 pfeerick

I suspect the top three "model setup" buttons were done that way to signify active/inactive, but not sure about all the other buttons.

pfeerick avatar Sep 12 '22 00:09 pfeerick

comparing for example the Internal RF button with the Betaflight setup button in your screen shots I'd say they use different background colors. Same conclusion when looking at my screen shots.

mha1 avatar Sep 12 '22 01:09 mha1

Buttons on the setup screen are based on lvgl button; on the tool screen - lvgl label. (openUI Button and TextButton).

eshifri avatar Sep 12 '22 20:09 eshifri

Buttons on the setup screen are based on lvgl button; on the tool screen - lvgl label. (openUI Button and TextButton).

Hi, what does that mean in terms of a solution?

mha1 avatar Sep 14 '22 16:09 mha1

I do not know, to be honest. :-) Just a hint to somebody who implemented it.

eshifri avatar Sep 14 '22 16:09 eshifri

These are basically 2 kinds of buttons:

  • those that can have 2 states (i.e. status indicator; internal module, trainer, etc...)
  • those that have only 1 state (simple push buttons)

If everyone agrees the second type should have the same color as the first in "unactivated state", then let's do it this way.

raphaelcoeffic avatar Sep 15 '22 09:09 raphaelcoeffic

@raphaelcoeffic It's not exactly everyone that agreed already but can you work with two out of everyone?

mha1 avatar Sep 26 '22 09:09 mha1

Well, it's three of the everyone present, since he suggested it :-P

pfeerick avatar Sep 26 '22 10:09 pfeerick

Four 😉

gagarinlg avatar Sep 26 '22 11:09 gagarinlg

Awesome approval rate engineering. Think in terms of major news outlet headlines: 50% increase in approval numbers. Just by sharp thinking. Plus motivated one additional voter. Are you a campaign manager?

mha1 avatar Sep 26 '22 11:09 mha1

Not sure you guy measure the consequences 😇 Anyways, here it is: #2367.

raphaelcoeffic avatar Sep 26 '22 13:09 raphaelcoeffic