edgetx icon indicating copy to clipboard operation
edgetx copied to clipboard

CRSF trainee input

Open gagarinlg opened this issue 3 years ago • 5 comments

Is there an existing issue for this feature request?

  • [X] I have searched the existing issues

Is your feature request related to a problem?

As more and more radios have ExpressLRS build in, a wireless trainer setup requires an external module on the trainee radio, when it has an internal ExpressLRS module.

Describe the solution you'd like

Add CRSF as a trainer input mode for the trainer plug and the external module slot, so that ExpressLRS receivers can be used on the trainer radio to create a wireless trainer setup.

Describe alternatives you've considered

No response

Additional context

No response

gagarinlg avatar Sep 02 '22 15:09 gagarinlg

It is probably in need of some independent hardware testing and tweaking (ie. Raphael's comment about not keeping on adding new modes). I did test the CRSF input early on and it seemed to be working fine.

https://github.com/EdgeTX/edgetx/pull/1861

pfeerick avatar Sep 02 '22 23:09 pfeerick

Supporting CRSF Trainer on some serial input should be simple, and yes, we need to add a parameter for the protocol, as we are otherwise having more and more modes.

Regarding the serial input itself, we need a non-inverted UART, which is not available at the back of any radios, especially considering that at +400kbps, we don’t have the option of using software serial.

raphaelcoeffic avatar Sep 03 '22 04:09 raphaelcoeffic

Do we need to support high uart speeds? When you can not fly solo you probably do not get tge difference between 50 Hz and 500 Hz rates

gagarinlg avatar Sep 03 '22 05:09 gagarinlg

Do we need to support high uart speeds? When you can not fly solo you probably do not get tge difference between 50 Hz and 500 Hz rates

That is not the point: CRSF serial Rx use 420kbps by default, and I’m not sure you can configure them differently.

raphaelcoeffic avatar Sep 03 '22 05:09 raphaelcoeffic

Oh, I was not aware of that.

gagarinlg avatar Sep 03 '22 05:09 gagarinlg