edgetx icon indicating copy to clipboard operation
edgetx copied to clipboard

Correction of Japanese Kanji display

Open ToshihiroMakuuchi opened this issue 3 years ago • 3 comments

@pfeerick @raphaelcoeffic Fixed display of Kanji characters.

ToshihiroMakuuchi avatar Aug 04 '22 01:08 ToshihiroMakuuchi

Ok, so it looks like this replaces #2026? It looks fine to me, so if @raphaelcoeffic has no concerns in it goes...

pfeerick avatar Aug 04 '22 03:08 pfeerick

Just putting this up for later review... it seems like there is a mismatch between the output of tools/list-utf-8-code-points.py jp and the list in radio/src/fonts/lvgl/make_fonts.sh - there is a discrepancy in both lists - it's not like one is more complete than the other (i.e. the red highlighted codes don't appear in either list at all).

https://user-images.githubusercontent.com/5500713/183625718-6cfa2dac-daa4-462b-9270-b4c78460b988.mp4

pfeerick avatar Aug 09 '22 10:08 pfeerick

For some characters (Hiragana / Katakana) I added the full range (in form of a range) as there are only few of them. And for Kanji I added only those required, as there are too many of them (>50.000).

raphaelcoeffic avatar Aug 09 '22 11:08 raphaelcoeffic

@pfeerick You said that tools/charset.py was conflicted, but could not merge Japanese? What should I have done?

ToshihiroMakuuchi avatar Oct 02 '22 12:10 ToshihiroMakuuchi

#2026 was closed in favour of this PR since it was understood that it replaced it. But you've deleted the branch for this PR now. Was that intentional?

pfeerick avatar Oct 03 '22 11:10 pfeerick

@pfeerick It is not intentional. So we have created a new jp.h using the latest en.h.

ToshihiroMakuuchi avatar Oct 03 '22 14:10 ToshihiroMakuuchi

The changes from this PR have pulled into #2456, so will close this PR now.

pfeerick avatar Oct 11 '22 00:10 pfeerick