Threshold-Skin icon indicating copy to clipboard operation
Threshold-Skin copied to clipboard
verified publisher icon Edgarware

Frame.Focus.Text is now defined in specific color config

Open Jeddunk opened this issue 8 years ago • 2 comments

This is needed, because in Windows 10, certain colors (orange) have their titlebar text in black. While the way this has been implemented seems convoluted, it's necessary since it needs to be changed to white if the titlebar is set to black. The only issue now is that symbols (e.g. "Minimize", "Maximize",...) still stay white. This PR also fixes the Accent.Text value in orange.styles to be black.

Jeddunk avatar Jul 04 '17 22:07 Jeddunk

I completely forgot about the Titlebar Accent stuff, good catch.

I'd recommend keeping orange's Accent.Text white for now though. There's a lot of instances where black text would go with white icons, which doesn't look too great. Plus the titlebar text is actually an icon when the back button is showing (oh boy gross hacks) and it would seem weird for it to change colors when that button appears and disappears.

Edgarware avatar Jul 06 '17 00:07 Edgarware

it can be available that the Navigation Hamburger Button actually work like a real UWP?

Naibaowjk avatar Jul 26 '18 12:07 Naibaowjk