support icon indicating copy to clipboard operation
support copied to clipboard
verified publisher icon EddieHubCommunity

[REVIEW] Lakshay Pruthi

Open Lakshay-Pruthi opened this issue 3 years ago • 13 comments

Portfolio link

https://lakshay-pruthi.github.io/Portfolio-Website/

GitHub Repo Link

https://github.com/Lakshay-Pruthi/Portfolio-Website

Lakshay-Pruthi avatar Nov 28 '22 09:11 Lakshay-Pruthi

It's great having you contribute to this project

Welcome to the community :nerd_face:

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord Server and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

github-actions[bot] avatar Nov 28 '22 09:11 github-actions[bot]

@Lakshay-Pruthi brother your portfolio is very slow, try to optimize that

asifurrahaman754 avatar Dec 01 '22 16:12 asifurrahaman754

@Lakshay-Pruthi brother your portfolio is very slow, try to optimize that

In terms of loading?

Lakshay-Pruthi avatar Dec 01 '22 16:12 Lakshay-Pruthi

@Lakshay-Pruthi brother your portfolio is very slow, try to optimize that

In terms of loading?

Yes, especially the image takes time to load.

asifurrahaman754 avatar Dec 01 '22 17:12 asifurrahaman754

@Lakshay-Pruthi brother your portfolio is very slow, try to optimize that

In terms of loading?

Yes, especially the image takes time to load.

Ya! I noticed it yesterday, so, Changed all of them to .webp format. Could you check again and see if still, it is taking time?

Lakshay-Pruthi avatar Dec 02 '22 05:12 Lakshay-Pruthi

@Lakshay-Pruthi well-done bro! it's a lot faster now

asifurrahaman754 avatar Dec 02 '22 06:12 asifurrahaman754

@Lakshay-Pruthi mention experience in your portfolio, if you have any

theritikchoure avatar Dec 03 '22 05:12 theritikchoure

@Lakshay-Pruthi mention experience in your portfolio, if you have any

I don't have any professional experience now. Should I mention my open-source contributions?

Lakshay-Pruthi avatar Dec 03 '22 06:12 Lakshay-Pruthi

@Lakshay-Pruthi mention experience in your portfolio, if you have any

I don't have any professional experience now. Should I mention my open-source contributions?

yes you can

theritikchoure avatar Dec 03 '22 06:12 theritikchoure

Hey @asifurrahaman754 , I am little confused about the styling of the scrollbar. Is the scrollbar visibility good ? Basically Can you assume that there could be more content below?

Lakshay-Pruthi avatar Mar 19 '23 06:03 Lakshay-Pruthi

@Lakshay-Pruthi

I think you should do the reverse, which means you should style your scrollbar as like the background line and the background of the scrollbar should be the scrollbar style. Because when I saw the scrollbar I was a little confused by the style, I was like: should I go up or down? It is just my personal opinion.

asifurrahaman754 avatar Mar 19 '23 07:03 asifurrahaman754

@asifurrahaman754 I have made some changes. Check it out!

Lakshay-Pruthi avatar Mar 19 '23 10:03 Lakshay-Pruthi

@Lakshay-Pruthi now the ux is better, looks like you can scroll down

asifurrahaman754 avatar Mar 19 '23 11:03 asifurrahaman754