BioDrop icon indicating copy to clipboard operation
BioDrop copied to clipboard

data:Brownei

Open Brownei opened this issue 2 years ago • 7 comments

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

  • [ ] My code follows the code style of this project.
  • [ ] My change requires changes to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [ ] All new and existing tests passed.
  • [ ] This PR does not contain plagiarized content.
  • [ ] The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

Brownei avatar Mar 02 '23 11:03 Brownei

Welcome @Brownei! Thank you so much for your first pull request!

github-actions[bot] avatar Mar 02 '23 11:03 github-actions[bot]

Welcome @Brownei! Thank you so much for your first pull request!

github-actions[bot] avatar Mar 02 '23 11:03 github-actions[bot]

What's wrong with the bio part it's too long, brief in 1-2 lines.

SurajPratap10 avatar Mar 02 '23 13:03 SurajPratap10

What's wrong with the bio part it's too long, brief in 1-2 lines.

@SurajPratap10 whilst there are advantages to having a short bio this is not a requirement and we encourage people to write the bios they want (and these can always be updated). Clearly there is nothing wrong with this bio - please do not write such rude and unsupportive messages in the future, this is not collaborative or welcoming.

SaraJaoude avatar Mar 03 '23 08:03 SaraJaoude

What's wrong with the bio part it's too long, brief in 1-2 lines.

@SurajPratap10 whilst there are advantages to having a short bio this is not a requirement and we encourage people to write the bios they want (and these can always be updated). Clearly there is nothing wrong with this bio - please do not write such rude and unsupportive messages in the future, this is not collaborative or welcoming.

It was too long that's why I told him to write a shorter bio as it gives greater engagement from a reader's POV. Sorry, if it looked rude I will take care of it in the future.

SurajPratap10 avatar Mar 03 '23 08:03 SurajPratap10

Thank you very much for the assistance

Brownei avatar Mar 03 '23 09:03 Brownei

@devvsakib please do not comment on people's bio's, it is their bio - also if you look further up the Pull request timeline you can see this has already been discussed

eddiejaoude avatar Mar 08 '23 22:03 eddiejaoude

Hi @Brownei I have fixed the json without changing any content from your bio (json does not accept line breaks/paragraphs) so I will now be merging your Profile

SaraJaoude avatar Mar 17 '23 02:03 SaraJaoude