BioDrop icon indicating copy to clipboard operation
BioDrop copied to clipboard

Replace fetches from internal APIs with function calls

Open dan-mba opened this issue 2 years ago • 1 comments

Description

The Next.js documentation explains that fetching data from an API route from the same server is a bad idea.

This was fixed for user profiles in #4997 .

The following pages need to be updated to follow the same style:

  • [ ] pages/map.js
  • [ ] pages/events.js - #5152
  • [ ] pages/account/statistics.js
  • [ ] pages/index.js - #5124
  • [ ] pages/search.js

dan-mba avatar Feb 25 '23 17:02 dan-mba

It's great having you contribute to this project

Welcome to the community :nerd_face:

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

github-actions[bot] avatar Feb 25 '23 17:02 github-actions[bot]

Hi @eddiejaoude and @dan-mba. I see that map.js, statistic.js and search.js files need to be replaced with function calls. I'm open to take this up :).

Harrish-Selvarajah avatar Apr 15 '23 20:04 Harrish-Selvarajah

Hi @eddiejaoude and @dan-mba. I see that map.js, statistic.js and search.js files need to be replaced with function calls. I'm open to take this up :).

@Harrish-Selvarajah Sorry I missed your comment. Work got stalled on this issue by the migration of loading profiles from the database. Then got combined with fixing some performance issues. Since there is only one file left, I will handle it to get this issue closed. Again, I apologize for not responding sooner.

dan-mba avatar May 20 '23 10:05 dan-mba

Hey @dan-mba, No worries! 😀

Harrish-Selvarajah avatar May 20 '23 10:05 Harrish-Selvarajah

All pages are migrated

dan-mba avatar May 20 '23 13:05 dan-mba