BioDrop icon indicating copy to clipboard operation
BioDrop copied to clipboard
verified publisher icon EddieHubCommunity

Feature: Dark Mode

Open ChinmayMhatre opened this issue 2 years ago • 19 comments

Wanted to Create a Draft a PR to get feedback while progressing

closes #2957

ChinmayMhatre avatar Feb 17 '23 09:02 ChinmayMhatre

image

would love feedback on the events page

ChinmayMhatre avatar Feb 18 '23 07:02 ChinmayMhatre

image docs home page

ChinmayMhatre avatar Feb 18 '23 07:02 ChinmayMhatre

image search page

ChinmayMhatre avatar Feb 18 '23 07:02 ChinmayMhatre

image map page

ChinmayMhatre avatar Feb 18 '23 07:02 ChinmayMhatre

image can we use white/10 instead of plain white?

ManishBisht777 avatar Feb 18 '23 13:02 ManishBisht777

Looks good :)

ManishBisht777 avatar Feb 18 '23 13:02 ManishBisht777

image can we use white/10 instead of plain white?

For the bio?

ChinmayMhatre avatar Feb 18 '23 13:02 ChinmayMhatre

image can we use white/10 instead of plain white?

For the bio?

i am thinking of all the borders as plain white is being used for text

ManishBisht777 avatar Feb 18 '23 13:02 ManishBisht777

image can we use white/10 instead of plain white?

For the bio?

i am thinking of all the borders as plain white is being used for text

Makes sense

ChinmayMhatre avatar Feb 18 '23 14:02 ChinmayMhatre

Getting this error when I navigate to the quickstart guide in my local repo. No Idea what this means. image

ChinmayMhatre avatar Feb 19 '23 10:02 ChinmayMhatre

I also have trouble targetting the heading the the mdx files. image

ChinmayMhatre avatar Feb 19 '23 10:02 ChinmayMhatre

Hey @ManishBisht777 , sorry for the ping. Could you take a look at the PR .See if I missed anything. Thanks

ChinmayMhatre avatar Feb 23 '23 12:02 ChinmayMhatre

Hey @ManishBisht777 , sorry for the ping. Could you take a look at the PR .See if I missed anything. Thanks

sure

ManishBisht777 avatar Feb 23 '23 16:02 ManishBisht777

Great work @ChinmayMhatre, the changes are looking great :raised_hands:

found 2 things

We can make outlines and borders as light gray as in the profile card image

on /docs/contribution/storybook seems a bit dark

image

ManishBisht777 avatar Feb 23 '23 16:02 ManishBisht777

I'll try to fix these by today

ChinmayMhatre avatar Feb 27 '23 06:02 ChinmayMhatre

@ManishBisht777 any idea how to fix the /docs/contribution/storybook thing? I tried changing the :visited tag's css . but it changes it across the app.

ChinmayMhatre avatar Mar 01 '23 07:03 ChinmayMhatre

Hey @eddiejaoude , Could you give feedback on this. Sorry for the ping, I felt this would keep getting delayed if more ui sections are added in the other PRs. So maybe those could come in separate PRs. Would like any suggestions for code refactoring or any bug you see.

ChinmayMhatre avatar Mar 03 '23 17:03 ChinmayMhatre

@ChinmayMhatre Sorry for the late reply, I also couldn't find a way to style the link as we have to put the styles in golal.css but that actually does reflect throughout the app.

can we add a file.module.css just for the docsLayout? because that file will only be present locally

ManishBisht777 avatar Mar 05 '23 03:03 ManishBisht777

Could you give feedback on this. Sorry for the ping

no problem, sorry I have so many PRs to go through, I will go through this in the next few days

eddiejaoude avatar Mar 05 '23 03:03 eddiejaoude

Sorry I keep missing this, because chore: profile label got added, I will remove now and add it to my list of PRs to go through soon

eddiejaoude avatar Mar 14 '23 02:03 eddiejaoude

Sorry for my slow review, I have left some inline comments

Totally understand Eddie! Will take a look at the suggestions

ChinmayMhatre avatar Mar 25 '23 05:03 ChinmayMhatre