BioDrop icon indicating copy to clipboard operation
BioDrop copied to clipboard

Navigation is very slow and doesn't work at times.

Open FrozenHearth opened this issue 3 years ago • 11 comments

Description

When items in the navbar are clicked, sometimes, the navigation is very slow, and sometimes one has to click multiple times for the navigation to work.

Screenshots

https://user-images.githubusercontent.com/27160715/211837965-2c261768-d849-4b70-98a7-83efda1f0318.mov

Additional information

Chrome: Latest version OS: Mac OS Monterey 12.5.1

FrozenHearth avatar Jan 11 '23 14:01 FrozenHearth

It's great having you contribute to this project

Welcome to the community :nerd_face:

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

github-actions[bot] avatar Jan 11 '23 14:01 github-actions[bot]

Also related, in Navbar.js,

The anchor tag is missing the target and rel attributes. Is this intentional?

                  <a
                    href="https://github.com/EddieHubCommunity/LinkFree"
                    aria-current="page"
                  >
                    <IconContext.Provider
                      value={{
                        color: "white",
                        style: { verticalAlign: "middle" },
                      }}
                    >
                      <FaGithub />
                    </IconContext.Provider>
                  </a>

FrozenHearth avatar Jan 11 '23 15:01 FrozenHearth

I also have the same experience both laptop and mobile device. Maybe we can fix that or add a loader animation specially when searching

KimberlyPangilinan avatar Jan 11 '23 18:01 KimberlyPangilinan

Well, I feel naturally the route transitions should be seamless. A loader will be a nice temporary fix, but we need to find out why the route changes are taking time.

FrozenHearth avatar Jan 11 '23 21:01 FrozenHearth

Thanks for raising the issue. Yes search page is the slowest because it loads all the profiles. I think this issue is a duplicate of https://github.com/EddieHubCommunity/LinkFree/issues/2815 ?

eddiejaoude avatar Jan 12 '23 09:01 eddiejaoude

@eddiejaoude Thanks for replying! Along with the search, the other links also load sort of slow. If a PR fixes #2815 , and if it autofixes this issue, then I think we can reference this and that issue in the PR. :)

FrozenHearth avatar Jan 12 '23 09:01 FrozenHearth

I have made improvements to the profile page also, I think there is a performance improvement by 50%

eddiejaoude avatar Jan 15 '23 21:01 eddiejaoude

@eddiejaoude The profile page improvements PR is merged?

FrozenHearth avatar Jan 16 '23 20:01 FrozenHearth

Yes 👍 https://github.com/EddieHubCommunity/LinkFree/pull/3477

eddiejaoude avatar Jan 16 '23 20:01 eddiejaoude

Awesome! :)

FrozenHearth avatar Jan 16 '23 20:01 FrozenHearth

@eddiejaoude I was thinking we could have a progress bar when switching routes. That would clearly indicate a loading state. Right now, we are having to click the chips multiple times for example, to navigate to a page. Clicking once also navigates, but it is slow, so naturally, I thought my click didn't go through, and clicked twice.

FrozenHearth avatar Jan 17 '23 17:01 FrozenHearth

Can you profile the pages loading time with Chrome?

eddiejaoude avatar Jan 22 '23 07:01 eddiejaoude

@eddiejaoude Could you please guide me as to how to do that? I've tried Chrome's Performance Insights. Not sure if you're referring to the same?

FrozenHearth avatar Jan 22 '23 12:01 FrozenHearth

Further performance improvements have been made since the above comments.

Additionally, there is an open Pull Request for a progress loader - however this has been parked for the moment because of the new features introduced in the latest NextJS.

I will close this for now, but feel free to raise a new issue with specific criteria.

SaraJaoude avatar Feb 03 '23 15:02 SaraJaoude