BioDrop icon indicating copy to clipboard operation
BioDrop copied to clipboard

issue #2562 fix

Open AldrinSeanPereira opened this issue 3 years ago • 9 comments

this fix is for issue #2562 where I have set transformInLineCode to true

closes #2562

Fixes Issue

#2562

Changes proposed

Check List (Check all the applicable boxes)

  • [x] My code follows the code style of this project.
  • [ ] My change requires changes to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [x] All new and existing tests passed.
  • [x] This PR does not contain plagiarized content.
  • [x] The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

I need more advice for this PR to check if it is correct

AldrinSeanPereira avatar Jan 01 '23 14:01 AldrinSeanPereira

Welcome @AldrinSeanPereira! Thank you so much for your first pull request!

github-actions[bot] avatar Jan 01 '23 14:01 github-actions[bot]

Thank you Sean! Can you add a screenshot of before and after please

eddiejaoude avatar Jan 01 '23 15:01 eddiejaoude

just to clarify: do you want me to add screenshots of the code changes? I'm not sure what to screenshot otherwise

AldrinSeanPereira avatar Jan 01 '23 16:01 AldrinSeanPereira

Sorry for the confusion. Not the code changes because I can see the code changes in the files changed tab. But it would be useful to see what effect the change the config file had to the docs that are created to see if the inline code is now rendered and the issue #2562 is resolved.

eddiejaoude avatar Jan 01 '23 16:01 eddiejaoude

Ah I got it! I shall do that. Thank you Eddie!

AldrinSeanPereira avatar Jan 01 '23 16:01 AldrinSeanPereira

im stuck in finding the new (and correct) stuff to be displayed

the old error which @Pradumnasaraf had shown is in this link: https://linkfree.eddiehub.io/docs/contributing/hacktoberfest

AldrinSeanPereira avatar Jan 01 '23 16:01 AldrinSeanPereira

In order for this to work correctly, the following code needs to be added to styles/globals.css before the tailwind imports:

code.language-unknown::before, code.language-unknown::after {
  content: ""
}

Then the hacktoberfest docs will look like the following: hacktoberfest

dan-mba avatar Jan 01 '23 18:01 dan-mba

Hey @dan-mba I have now updated the styles/global.css file as you have specified. Is it correct?

AldrinSeanPereira avatar Jan 14 '23 12:01 AldrinSeanPereira

Hey @dan-mba I have now updated the styles/global.css file as you have specified. Is it correct?

@AldrinSeanPereira The styles change looks good. Now you need to fix next.config.mjs like I mentioned here

dan-mba avatar Jan 14 '23 13:01 dan-mba

Thank you @schmelto for getting this fixed. Thank you @dan-mba for your help 🙌🏼 I had been busy with work and unfortunately forgot to get back to this.

AldrinSeanPereira avatar Jan 23 '23 15:01 AldrinSeanPereira

Great collab everyone 👍

eddiejaoude avatar Jan 23 '23 23:01 eddiejaoude