BioDrop icon indicating copy to clipboard operation
BioDrop copied to clipboard

[FEATURE] Donate button linking to GitHub Sponsors

Open eddiejaoude opened this issue 3 years ago • 13 comments

Description

We have social icons but it would be great to have a donate button, that linked to their GitHub Sponsor profile

Screenshots

Screenshot 2022-12-06 at 13 36 07

https://linkfree.eddiehub.io/eddiejaoude

Additional information

No response

eddiejaoude avatar Dec 03 '22 07:12 eddiejaoude

It's great having you contribute to this project

Welcome to the community :nerd_face:

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

github-actions[bot] avatar Dec 03 '22 07:12 github-actions[bot]

You can add a link with your link to a GitHub Sponsors or any other donations service profile. But having a button would be interesting too.

Panquesito7 avatar Dec 04 '22 01:12 Panquesito7

This would be a wonderful addition

Pradumnasaraf avatar Dec 04 '22 16:12 Pradumnasaraf

@eddiejaoude can you please let me know which page are you referring to on the site?

dheesimha avatar Dec 06 '22 00:12 dheesimha

@dheesimha people can add it as a link as mentioned by @Panquesito7 but I think if we have a special section in their json for donation and we can make it more prominent on the page - maybe bottom left for example

eddiejaoude avatar Dec 06 '22 08:12 eddiejaoude

@eddiejaoude ,thanks for responding.I am new to Eddiehub, discovered you on Sunday via FreeCodeCamp's youtube channel and found your community very interesting and thought it was a perfect opportunity for me to get started with Open Source.

Hence I came across this issue, and I was unclear about which site was being referred over here. Could you please link the site you are talking about, so that I can understand the issue thoroughly and what needs to be done?

Thanks.

dheesimha avatar Dec 06 '22 11:12 dheesimha

@dheesimha sorry for not being clearer, I have updated the description with a link and a screenshot - if you need more info let me know

eddiejaoude avatar Dec 06 '22 13:12 eddiejaoude

Thanks a lot for updating the description @eddiejaoude . Now it's perfectly clear what the requirement is. So as per my understanding, we would require a button that says donate in the bottom left corner and display that only if the person has enabled the sponsor option on GitHub, right?

dheesimha avatar Dec 07 '22 00:12 dheesimha

yes that I correctly, I was initially thinking if they have adding the json property sponsored with a link, but you are correct, we could check if it is enabled on their GitHub via the GitHub API

eddiejaoude avatar Dec 07 '22 07:12 eddiejaoude

Cool then. I would like to take up this issue and work on it . Could you please assign this to me @eddiejaoude ?

dheesimha avatar Dec 07 '22 23:12 dheesimha

Assigned 👍

eddiejaoude avatar Dec 08 '22 18:12 eddiejaoude

I think this would work well using the same style as the help button on the home page, so on the profile page it would appear Sponsor if they have it setup

Screenshot 2022-12-10 at 05 16 40

eddiejaoude avatar Dec 10 '22 05:12 eddiejaoude

Cool.I'll keep that in mind !

dheesimha avatar Dec 13 '22 04:12 dheesimha

anybody working on this issue??

alokVerma749 avatar Jan 26 '23 20:01 alokVerma749

@dheesimha are you working on this?

ChinmayMhatre avatar Jan 27 '23 06:01 ChinmayMhatre

I have unassigned the issue as there has been no recent activity.

SaraJaoude avatar Feb 03 '23 14:02 SaraJaoude

Can I work on this?

sansarmaske avatar Feb 11 '23 14:02 sansarmaske

Can I work on this?

@sansarmaske I have assigned this to you

SaraJaoude avatar Feb 12 '23 02:02 SaraJaoude

Q: Won't there be 2 button there, one for the testimonials and another for sponsors? wouldn't that be too much

gptkrsh avatar Feb 12 '23 07:02 gptkrsh

Q: Won't there be 2 button there, one for the testimonials and another for sponsors? wouldn't that be too much

good spot, this issue was created before we had testimonials - but the button could go on the left side

eddiejaoude avatar Feb 12 '23 09:02 eddiejaoude

On smaller screens that will still overflow :thinking:

gptkrsh avatar Feb 12 '23 10:02 gptkrsh

Maybe we can put Sponsor button above testimonials button for mobile view? And also, we can rename the button to Add Testimonial instead of Add Testimonial for [user] image

sansarmaske avatar Feb 12 '23 10:02 sansarmaske

I do not think we should put that many things down the bottom 🤔 Most people do not have more than 4-5 socials, it would be a good idea to put a button there IMO image

gptkrsh avatar Feb 12 '23 10:02 gptkrsh

We can also put it below social media icons. What do you think @eddiejaoude ?

sansarmaske avatar Feb 12 '23 11:02 sansarmaske

I am thinking we should close this issue for now, as we have no clear solution and people are adding this to their list of links

Thank you all for working through this together, great collaboration 💪

eddiejaoude avatar Feb 13 '23 03:02 eddiejaoude