BioDrop icon indicating copy to clipboard operation
BioDrop copied to clipboard
verified publisher icon EddieHubCommunity

Add Dark Mode Support

Open Keshraf opened this issue 3 years ago • 5 comments

Fixes Issue

Closes #1838

Changes proposed

  1. Added Dark Mode Support in Tailwind Config File
  2. Installed next-themes package which enables us to change to dark mode programmatically
  3. Added Dark Mode Toggle Button
  4. Fixed Text that weren't changing on switching

Check List (Check all the applicable boxes)

  • [x] My code follows the code style of this project.
  • [x] My change requires changes to the documentation.
  • [x] I have updated the documentation accordingly.
  • [x] All new and existing tests passed.
  • [x] This PR does not contain plagiarized content.
  • [x] The title of my pull request is a short description of the requested changes.

Screenshots

Screenshot 2022-10-03 at 8 04 21 PM Screenshot 2022-10-03 at 8 04 29 PM Screenshot 2022-10-03 at 8 04 55 PM Screenshot 2022-10-03 at 8 05 07 PM

Note to reviewers

I found that the menu button for mobile-view doesn't work, should I create a new issue and PR for it?

Keshraf avatar Oct 03 '22 14:10 Keshraf

How can I fix this?

I would also be open to suggestions on my work.

Keshraf avatar Oct 03 '22 14:10 Keshraf

Sorry @Keshraf for my slow reply, I will take a look today

eddiejaoude avatar Oct 13 '22 03:10 eddiejaoude

I found that the menu button for mobile-view doesn't work, should I create a new issue and PR for it?

I just saw your comment @Keshraf, it would be better to fix it in this PR

eddiejaoude avatar Oct 13 '22 03:10 eddiejaoude

Okay @eddiejaoude, I will fix it in this PR 👍

Keshraf avatar Oct 13 '22 08:10 Keshraf

Welcome @Keshraf! Thank you so much for your first pull request!

github-actions[bot] avatar Oct 13 '22 08:10 github-actions[bot]

Sorry @Keshraf I just realised we might be talking about different menu buttons. Are you talking about the light/dark mode or the "hamburger" one? If for the existing button that is not required for this PR, sorry I assumed you meant for your new button

Please clarify and we can hopefully get this merged soon, thanks 👍

eddiejaoude avatar Oct 28 '22 09:10 eddiejaoude

Sorry @Keshraf I just realised we might be talking about different menu buttons. Are you talking about the light/dark mode or the "hamburger" one? If for the existing button that is not required for this PR, sorry I assumed you meant for your new button

Please clarify and we can hopefully get this merged soon, thanks 👍

I was talking about the "hamburger menu" button. Should I add it to this PR?

Keshraf avatar Oct 28 '22 14:10 Keshraf

Yes please, if you can add it to this PR as it is related to the changes here 👍

Sorry you have some conflicts to resolve now because other PRs have been merged in

eddiejaoude avatar Oct 28 '22 14:10 eddiejaoude