BioDrop icon indicating copy to clipboard operation
BioDrop copied to clipboard

[FEATURE] Add Dark Mode

Open Keshraf opened this issue 3 years ago • 13 comments

Description

EddieHub is a community of developers and open-source enthusiasts. And who doesn't love dark mode more than them? I would like to add dark mode support.

Please assign this issue to me and attach the Hackoberfest label.

Screenshots

No response

Additional information

🌚

Keshraf avatar Oct 01 '22 03:10 Keshraf

It's great having you contribute to this project

Welcome to the community :nerd_face:

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

github-actions[bot] avatar Oct 01 '22 03:10 github-actions[bot]

Hey @vasucp1207, actually I added this issue as I wanted to work on it. I am waiting for a maintainer to assign this issue to me. You can create more issues and work on them instead

Keshraf avatar Oct 01 '22 08:10 Keshraf

We would want it on the navbar, also we need to look up media queries as well

gptkrsh avatar Oct 01 '22 08:10 gptkrsh

Sorry, @Keshraf I do not read the full description.

vasucp1207 avatar Oct 01 '22 08:10 vasucp1207

Sorry, @Keshraf I do not read the full description.

Not a problem. Don't worry about it. There are a lot more things you contribute to!

Keshraf avatar Oct 01 '22 08:10 Keshraf

Sure @Keshraf go ahead. Please make this addition to the next-js branch instead of the current main branch so that it will be included in v2 of linkfree

EmmaDawsonDev avatar Oct 01 '22 08:10 EmmaDawsonDev

Okay understood. Thank you for letting me know!

Keshraf avatar Oct 01 '22 08:10 Keshraf

Hey actually i have worked on this issue already, as it was raised earlier as well, so if @Keshraf is not able to implement this feature i can help, just do let me know.

Vedant-Manjrekar avatar Oct 01 '22 09:10 Vedant-Manjrekar

Hey actually i have worked on this issue already, as it was raised earlier as well, so if @Keshraf is not able to implement this feature i can help, just do let me know.

Oh sorry, I didn't know someone was already working on this. What's the issue number?

EmmaDawsonDev avatar Oct 01 '22 10:10 EmmaDawsonDev

Hey actually i have worked on this issue already, as it was raised earlier as well, so if @Keshraf is not able to implement this feature i can help, just do let me know.

Oh sorry, I didn't know someone was already working on this. What's the issue number?

It's #1032

Vedant-Manjrekar avatar Oct 01 '22 10:10 Vedant-Manjrekar

Ok, this is a bit difficult since the issue was never assigned and the last message is from august so it looks abandoned but we can do like this.

Vedant - make your PR to the main branch as it looks like you made yours in prime react (no need to ask to make a PR) Keshraf - make a version for the next-js branch instead.

hope that works for everyone

EmmaDawsonDev avatar Oct 01 '22 10:10 EmmaDawsonDev

That works for me!

Keshraf avatar Oct 01 '22 10:10 Keshraf

Works for me as well.

Vedant-Manjrekar avatar Oct 01 '22 10:10 Vedant-Manjrekar

there is an issue opened similar to this #2957 I want to work on this @Keshraf are you working on this

ManishBisht777 avatar Jan 27 '23 20:01 ManishBisht777

Thank you for raising this idea, but I will be closing this issue as #2957 deals with the same subject and has more discussions.

SaraJaoude avatar Feb 03 '23 07:02 SaraJaoude