consul-api icon indicating copy to clipboard operation
consul-api copied to clipboard

AbstractHttpTransport#logRequest always constructs message despite of logging level

Open robotmrv opened this issue 1 year ago • 0 comments

https://github.com/Ecwid/consul-api/blob/232550b44e122f42446876835946baf2de333f53/src/main/java/com/ecwid/consul/transport/AbstractHttpTransport.java#L133C15-L163C25

Since it logs only at finest level it is reasonable to add short cut check for log level before message construction

if (!loger.isLoggable(Level.FINEST)) {
    return;
}

to avoid unnecessary memory allocations.

robotmrv avatar Apr 04 '24 16:04 robotmrv