EcomDev_PHPUnit
EcomDev_PHPUnit copied to clipboard
Wrong Modulename detection in \EcomDev_PHPUnit_Model_App::getModuleNameByClassName
Modulename detection is not working correctly when Modules like these exists:
N98_Catalog N98_CatalogGrouped
foreach ($this->getConfig()->getNode('modules')->children() as $module) {
if (strpos($className, $module->getName()) === 0) {
$moduleName = $module->getName();
break;
}
}
By using strpos, the function will always return N98_Catalog.
This should be :
if (strpos($className, $module->getName() . '_' ) === 0)
@kezek Can you please create it as a pull request to dev branch, so you input will be mentioned in the contributions on github?
Sorry Ivan , was away during that time but I see Sebastian took care of it so it's all good. Cheers