EasyPost
Use fixture submodule for unit tests
Description
- Parse fixture JSON from submodule into dictionaries
- Unit tests updated to use new fixture data
- Tweaked some bad unit test values
- Re-recorded all cassettes
Testing
- All unit tests updated to use new fixture solution
- Fixed some bad unit test data
- Re-recorded all cassettes since many fixtures changed.
Pull Request Type
Please select the option(s) that are relevant to this PR.
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [x] Improvement (fixing a typo, updating readme, renaming a variable name, etc)
It doesn't make sense for us to do this in parallel with the rewrite as the work will just need to get redone later.
I feel like I've looked over these already so much with the rewrite 😂 Can we merge that and then just use the fixtures on the v4 branch instead once landed? I see no benefit do double dipping if we'll have to re-review for v4 here shortly and it'll get replaced with that eventually.
The v4 and rewrite branches are not using the submodule. That's what this is for.
The v4 and rewrite branches are not using the submodule. That's what this is for.
Right, I'm suggesting we save us all some work by only doing it on the v4 branch so that when that gets merged to master, we only needed to do the work once instead of twice. At present, the master branch is going to get this change but we'll need to make the same changes on the v4 branch to catch it up.
The v4 and rewrite branches are not using the submodule. That's what this is for.
Right, I'm suggesting we save us all some work by only doing it on the v4 branch so that when that gets merged to master, we only needed to do the work once instead of twice. At present, the master branch is going to get this change but we'll need to make the same changes on the v4 branch to catch it up.
Understood, we'll hold off on this until the rewrite thread-safe PR is adopted.