easy-deploy-bundle icon indicating copy to clipboard operation
easy-deploy-bundle copied to clipboard

deploy_dir per server

Open BNEP opened this issue 6 years ago • 2 comments

Hello, it would be nice having ther deploy_dir (deployDir) configurable per server because different servers could have different paths to web DocRoot. To get this benefit i made some changes in the code:

src/Deployer/DefaultDeployer.php:188 foreach ($appServers as $server) { $this->log(sprintf('<h3>Setting the %s property for <server>%s</> server</>', Property::deploy_dir, $server)); // BNEP modified: we want to set deploy_dir per server if not set with ->deployDir() if(empty(Property::deploy_dir)){ $server->set(Property::deploy_dir, $this->getConfig(Option::deployDir)); } } src/Configuration/DefaultConfiguration.php:364 protected function getReservedServerProperties(): array { return [Property::bin_dir, Property::config_dir, Property::console_bin, Property::cache_dir, /* ***BNEP modified: deploy_dir should be possible to set per server *** Property::deploy_dir, */ Property::log_dir, Property::src_dir, Property::templates_dir, Property::web_dir]; } Maybe you could put that in master? Regards

BNEP avatar Jan 14 '20 13:01 BNEP

I have the same need and make the PR to add this feature.

Thanks for review.

romainjanvier avatar Apr 28 '21 09:04 romainjanvier

+1, I have the same need

four-li avatar Aug 27 '21 02:08 four-li