EasyAdminBundle icon indicating copy to clipboard operation
EasyAdminBundle copied to clipboard

Show form error messages for collection entry

Open dragosprotung opened this issue 3 years ago • 5 comments

After #5075 error messages are not rendered anymore. This patch will show them, restoring the previous "design".

We could manually render the form errors and maybe even show some info in the accordion tab, but this is out of scope for now.

dragosprotung avatar Jun 21 '22 08:06 dragosprotung

If we did that change to fix some bug ... if we revert it, the bug will happen again. What can we do here?

javiereguiluz avatar Jun 21 '22 17:06 javiereguiluz

This PR does not change the original fix. When defining the row you need to take care of rendering all the widget components. By making the change in #5075 the row now is missing the errors. With this PR we basically render the error block as well.

See https://symfony.com/doc/5.4/form/form_customization.html for what the form row should/can contain.

dragosprotung avatar Jun 21 '22 18:06 dragosprotung

We could also add the {{- form_errors(form) -}} to the collection_entry_row block for the same effect

dragosprotung avatar Jun 21 '22 18:06 dragosprotung

@javiereguiluz any chance you had some time to look into this ?

dragosprotung avatar Jul 21 '22 20:07 dragosprotung

@javiereguiluz anything new regarding this issue ?

dragosprotung avatar Nov 30 '22 14:11 dragosprotung