ExpressionToCode icon indicating copy to clipboard operation
ExpressionToCode copied to clipboard

Support for byte array constants

Open girlpunk opened this issue 3 years ago • 1 comments

I'd like to add support for byte array constants, these are currently failing in ExpressionToCodeImpl.DispatchConstant. Should this go in PlainObjectToCode, or is there a more appropriate place?

girlpunk avatar Sep 06 '22 12:09 girlpunk

What kind of example code are you thinking of? I'm not quite sure what you're trying to achieve, so I'm not positive that's the best spot, but it certainly sounds reasonable ;-). More specifically, most new features tend to mostly touch ObjectToCodeImpl.cs and ExpressionToCodeImpl.cs

Be aware that I've decided to reorganize the public API (#253) so that I can avoid IObjectStringifier entirely. And I'm going to take this compat-breaking opportunity to use new C# features like records in the public api instead of the custom fluent syntax for configuration. The timing isn't coincidental; I'd like to push a new version including your additions in #245; but those depend on IObjectStringifier - which is the right place to put them in the then version of the codebase, but rather inconvenient to library consumers, because IObjectStringifier itself makes little sense.

I've tried to do the "big codebase shuffles" first, so I hope that if you split from master today you're unlikely to have merge conflicts, but make sure you're not using the codebase as of a few weeks ago; you're sure to have annoying mergeconflicts then.

I don't intend to do any dramatic reorganizations of ObjectToCodeImpl.cs and ExpressionToCodeImpl.cs, to avoid merge conflict likelihood.

EamonNerbonne avatar Sep 07 '22 08:09 EamonNerbonne