qmxgraph icon indicating copy to clipboard operation
qmxgraph copied to clipboard

Update the selenuim web driver used to run javascript tests

Open prusse-martin opened this issue 3 years ago • 4 comments

After updating "prettier" pre-commit hook to "v3.0.0-alpha.0" PhantomJS started to fail parsing the javascript source due new trailing commas, the command line option --trailing-comma=none will avoid that.

We need:

  • Update the selenium web driver user to run tests (chromiun?); ~~- or find out how to pass the trailing-comma flag via pre-commit hook;~~ ~~- or keep living using "prettier 2.7.1";~~

The trailing-comma option is being passed using the .prettierrc file. Updating is relevant because newer qt support more recent javascript syntax support that can't be properly used because PhantomJS does not support it.

prusse-martin avatar Sep 19 '22 20:09 prusse-martin

I personally do like the trailing commas =) it looks good.

prusse-martin avatar Sep 20 '22 20:09 prusse-martin

Did #142 fixed this?

nicoddemus avatar Oct 04 '22 11:10 nicoddemus

Give we can update prettier an have if working with phantomjs, yes.

But it will really be nice to be able to use modern javascript syntax and features and phantomjs is not being updated: https://github.com/ariya/phantomjs/issues/15344

prusse-martin avatar Oct 04 '22 13:10 prusse-martin

Ahh my bad, this is about updating the driver... had too many tabs open and got confused hehehe.

nicoddemus avatar Oct 04 '22 15:10 nicoddemus