HiGHS icon indicating copy to clipboard operation
HiGHS copied to clipboard

Error reading Fixed format MPS files

Open rolfvdhulst opened this issue 1 year ago • 3 comments

Highs currently fails to read the MIPLIB 2017 collection instance "rvb-sub". The issue appears to be that the free format incorrectly classifies the file as not fixable, even though the fixed format mps reader can read it just fine. In particular, the MPS file starts with:

NAME          rvb-sub
ROWS
 E  s0        $t5                  0

but the last line is incorrectly classified as not being interpretable in fixed format by the free format reader.

I will submit a PR that fixes this soon.

rolfvdhulst avatar Jul 29 '24 12:07 rolfvdhulst

Interesting: the problem here is that the file has comments at the end of non-comment lines. I've never seen this feature in an MPS file.

It's possible that this will be done for a free format MPS file, so I can't accept your fix.

The correct fix is to ignore any characters after a $ sign

jajhall avatar Sep 07 '24 16:09 jajhall

Closed by #1920

jajhall avatar Sep 12 '24 09:09 jajhall

The fix causes the MPS reader to fail on models for which there are $ or * characters in row/column names. See #1945

For the time being, revert the fix, so reopen this issue

jajhall avatar Sep 25 '24 09:09 jajhall