NotesReview icon indicating copy to clipboard operation
NotesReview copied to clipboard

Add the ability to specify and/or or quoted searches

Open peternewman opened this issue 4 years ago • 4 comments

E.g. if you want to search for a particular StreetComplete quest, you might want one or more words from the quest AND StreetComplete to be matched, it only seems to do OR by default.

peternewman avatar Aug 13 '21 12:08 peternewman

I think this might actually work by right now by putting all search terms in quotes. If you would like to search for notes created because a user could not answer the road surface quest, a search for "StreetComplete" "surface" "road" (note that each word is enclosed by quotation marks) should return the notes that you are interested in: https://ent8r.github.io/NotesReview/?view=map&query="StreetComplete" "surface" "road"&status=open Whereas searching for StreetComplete surface road (without the quotation marks) returns notes containing only one of the three words. Can you confirm that this is the case?

ENT8R avatar Sep 09 '21 19:09 ENT8R

Indeed it does, and I'm pleased to see that I can even search for a quoted string: https://ent8r.github.io/NotesReview/?view=map&query=%22StreetComplete%22%20%22"surface%20does%20this%20piece%20of%20road%22&status=open

Are you able to add that to the ? docs next to the search box? Ideally as a temporary measure until some fancier boolean stuff is supported, although I appreciate that may not be a priority for you (e.g. SC AND surface road OR surface steps).

Whereas searching for StreetComplete surface road (without the quotation marks) returns notes containing only one of the three words. Can you confirm that this is the case?

Yes, I searched for those terms (unquoted), and got at least matches for the first and middle on their own; I didn't specifically see road only, but that might just be down to the popularity of various terms and I didn't check extensively.

peternewman avatar Sep 10 '21 00:09 peternewman

Hmm, searching that way no longer seems to work. For example I wanted to find all notes containing both GPS Trace and StreetComplete 44. strings. It no longer finds anything, with or without quotes :cry: (neither do @peternewman examples linked above).

Only simple strings without quotes seems to work now (and behave as "find this exact phrase")

mnalis avatar Jul 16 '22 12:07 mnalis

Sorry for the inconvenience, the reason this no longer works the way I said it would is that a few months ago I tried to improve the performance of the search and unfortunately this led to some changes in the backend, including that the above "workaround" no longer works in the usual way.

My plan is that in the future, the AND as well as OR keywords will be recognized, allowing for much more granular filtering. If more than one word is entered, the AND filter is automatically activated, so that only those notes are guaranteed to be returned that also certainly contain both (or more) words.

ENT8R avatar Sep 22 '22 22:09 ENT8R